From: Taylor R Campbell <campbell@mumble.net>
Date: Sun, 10 Apr 2011 05:03:06 +0000 (+0000)
Subject: Add some disparaging comments about my code...yechhh.
X-Git-Tag: 20110426-Gtk~2^2~9
X-Git-Url: https://birchwood-abbey.net/git?a=commitdiff_plain;h=c2877e54b653f58eeba3b7ed04f8367c7a3059be;p=mit-scheme.git

Add some disparaging comments about my code...yechhh.
---

diff --git a/src/imail/imail-summary.scm b/src/imail/imail-summary.scm
index 59806b05c..382ec1aa7 100644
--- a/src/imail/imail-summary.scm
+++ b/src/imail/imail-summary.scm
@@ -367,6 +367,8 @@ SUBJECT is a string of regexps separated by commas."
 	(mark-temporary! mark))
       (buffer-put! buffer 'IMAIL-SUMMARY-MESSAGES (list->vector messages)))))
 
+;++ I am sorry to have written such a load of garbage.
+
 (define (expand-imail-summary-buffer buffer new-messages)
   (let ((old-messages (buffer-get buffer 'IMAIL-SUMMARY-MESSAGES #f))
 	(index-digits (buffer-get buffer 'IMAIL-SUMMARY-INDEX-DIGITS #f))
@@ -405,6 +407,10 @@ SUBJECT is a string of regexps separated by commas."
 			       old-messages
 			       mark*
 			       (cons new-message messages))))
+		     ;++ This can't possibly be right if we have just
+		     ;++ inserted some new messages.  We need to bump
+		     ;++ the old messages' indices, like we do when we
+		     ;++ expunge messages.
 		     ((eqv? (imail-summary-selected-message-index mark)
 			    (message-index old-message))
 		      (merge new-messages