Taylor R Campbell [Wed, 2 Jan 2019 06:10:52 +0000 (06:10 +0000)]
Load the fallback into rax so caller needs no conditional branch.
WARNING: This changes the amd64 compiled code interface so that new
compiled code requires a new microcode. (However, a new microcode
should handle old compiled code without trouble, since old compiled
code treats rax as garbage at this point, and LEA does not affect
flags.)
Taylor R Campbell [Mon, 31 Dec 2018 20:32:37 +0000 (20:32 +0000)]
Use BTS to affix single-bit type tags.
Taylor R Campbell [Sat, 29 Dec 2018 21:57:47 +0000 (21:57 +0000)]
Relax register constraints for tagging rule.
No need to keep the source alive here -- use move-to-target and allow
any temporary register instead.
Taylor R Campbell [Sat, 29 Dec 2018 16:40:02 +0000 (16:40 +0000)]
Simplify hook calls.
No need for CALL or the stack to be involved: just load PC-relative
address into RBX directly. Should shave off a few bytes of code.
WARNING: This changes the amd64 compiled code interface so that new
compiled code requires a new microcode and vice versa.
Taylor R Campbell [Sun, 30 Dec 2018 21:28:19 +0000 (21:28 +0000)]
Convert x86-64 to use rax as value register.
WARNING: This changes the amd64 compiled code interface so that new
compiled code requires a new microcode and vice versa.
Taylor R Campbell [Sun, 30 Dec 2018 21:01:00 +0000 (21:01 +0000)]
Allow careful use of available machine registers in RTL.
This will enable us to put fixed machine registers such as the value
register carefully into the RTL even if they are ordinarily available
as pseudo-register aliases for machine register allocation.
- CGEN-RINST calls TARGET-MACHINE-REGISTER! if the target of an RTL
instruction is a machine register that is ordinarily available for
register allocation.
- REGISTER-ALIAS declines to return any aliases reserved by
TARGET-MACHINE-REGISTER!, until...
- DELETE-DEAD-REGISTERS! makes the target machine registers available
again for REGISTER-ALIAS so that they can be chosen as targets.
(However, they still won't be chosen as temporaries.)
- MOVE-TO-ALIAS-REGISTER! -- which may be used only after all other
source registers have been chosen -- also allows the machine target
to be used as a source alias in order to avoid unnecessary register
motion.
- Don't propagate RTL references to available machine registers in
common subexpression elimination or in code compression.
Since the machine register might be allocated as an alias for another
register, it can't be moved around. The RTL generator ensures these
references appear only at the beginning or end of a block where the
machine register cannot be an alias for any live pseudo-register.
Taylor R Campbell [Sun, 30 Dec 2018 21:01:58 +0000 (21:01 +0000)]
Ensure register:value appears first or last in block.
Either it is the first register referenced, or the last register
assigned. This will enable us to use a machine register that is
normally available for register allocation, without having to worry
that it may be an alias for a live pseudo-register.
- In continuations that receive a value through register:value,
create a temporary register and make the first instruction be an
assignment of register:value to the temporary register, before we
the pop-extra.
The RTL optimizer avoids propagating this alias so the assignment
will stay in place, but later on, the LAP generator will take
advantage of the alias to avoid generating additional unnecessary
code.
- In returns that store a value in register:value, create a temporary
register and assign it where we used to assign to register:value,
and then store the temporary in register:value as the very last
instruction before pop-return after any frame-popping which might
involve temporaries.
Taylor R Campbell [Sun, 30 Dec 2018 21:26:16 +0000 (21:26 +0000)]
Optimize execute caches: avoid indirect jumps if possible.
No change to the compiled code interface: this just generates faster
code in execute caches if it can.
Taylor R Campbell [Sat, 29 Dec 2018 04:12:28 +0000 (04:12 +0000)]
Generate per-invocation jmp instructions.
I hypothesize that this will help the CPU's branch target predictor
be more precise than having a single jmp instruction inside an
assembly hook that actually jumps to an unknown procedure.
Empirically, this gives about 5x speed improvement for a
microbenchmark involving unknown procedure calls:
(define x (make-vector 1))
(define (test-01 x)
(define (g)
(vector-set! x 0 0))
(g)
((identity-procedure g)))
(define (test-10 x)
(define (g)
(vector-set! x 0 0))
((identity-procedure g))
(g))
(define (repeat n f x)
(show-time
(lambda ()
(do ((i 0 (fix:+ i 1)))
((fix:>= i n))
(f x)))))
; Before:
(repeat
10000000 test-01 x)
;process time: 1420 (1370 RUN + 50 GC); real time: 1427
; After:
(repeat
10000000 test-01 x)
;process time: 290 (220 RUN + 70 GC); real time: 312
Caveat: This is on top of a bunch of other experiments.
XXX Redo this in isolation.
WARNING: This adds hooks to the amd64 compiled code interface, so new
compiled code requires a new microcode. (However, a new microcode
should handle old compiled code just fine.)
Taylor R Campbell [Sat, 29 Dec 2018 01:11:00 +0000 (01:11 +0000)]
Use CALL/RET for pushing and returning to continuations on amd64.
Calls now look like:
;; (assign (register #x123) (cons-pointer tag (entry:continuation cont)))
(CALL (@PCR pushed))
(JMP (@PCR cont))
pushed:
(OR Q (@R ,rsp) (&U ,tag))
...
(JMP (@PCR uuo-link))
Returns now look like:
;; (pop-return)
(AND Q (@R ,rsp) (R ,regnum:datum-mask))
(RET)
These should happen in pairs, so that we can take advantage of the
CPU's return address branch target prediction stack rather than
abusing the indirect jump branch target predictor.
WARNING: This changes the amd64 compiled code interface, so new
compiled code requires a new microcode. (A new microcode might be
able to handle existing compiled code just fine.)
Taylor R Campbell [Fri, 28 Dec 2018 20:51:02 +0000 (20:51 +0000)]
Split compiled entries and compiled return addresses.
Reallocate tag 4 for return addresses.
This way, a compiled entry can be a pointer to a PC offsets so that
we can construct closures without dynamically generating code and
wrecking the instruction cache, while a compiled return addresses can
be a pointer to a PC, since we never dynamically create indirections
for returns.
For now, the runtime can handle both tags for return addresses.
XXX Only done and tested on x86-64 for now. Other architectures need
to be tested. Might be worthwhile to do this on i386 too, if anyone
still cares about i386.
WARNING: This changes the compiled code interface on all
architectures, so you'll have to build a new compiler running on an
old microcode and use that to compile a new system afresh.
Taylor R Campbell [Thu, 27 Dec 2018 03:58:38 +0000 (03:58 +0000)]
Use indirection for entry points on amd64.
A compiled entry is now a tagged address A pointing to a 64-bit word
W such that A + W points to instruction to execute.
This adds a memory indirection overhead to unknown procedure calls,
but it has the effect that consing a closure only involves writing
data memory, not instruction memory that must be reloaded into the
CPU's instruction cache.
WARNING: This changes the amd64 compiled code interface, so you'll
have to build a new compiler running on an old microcode and use that
to compile a new system afresh.
Taylor R Campbell [Thu, 20 Dec 2018 04:58:07 +0000 (04:58 +0000)]
Avoid CALL without RET for closure entries, hooks, and trampolines.
This will wreck the CPU's return address branch target predictor.
This is an intermediate change en route to using paired CALL/RET for
continuation pushes and pop-returns in order to take advantage of the
CPU's branch target predictor.
WARNING: This changes the format of compiled closures, and as such,
new compiled code requires a new microcode and vice versa.
Taylor R Campbell [Thu, 27 Dec 2018 03:58:50 +0000 (03:58 +0000)]
Eliminate return/entry compiled invocation pun.
There is a small cost to this. My hope is that it will be offset by:
1. distinguishing compiled entries from compiled return addresses, in
order to enable...
2. using indirection for compiled entries so closures don't need
dynamically generated code, and finally...
3. using direct instruction addresses for compiled return addresses
so we can exploit the return stack branch predictor,
which all requires this change in order to function correctly.
No change to compiled code interface intended.
Taylor R Campbell [Tue, 13 Aug 2019 14:26:13 +0000 (14:26 +0000)]
Use ln -n to avoid following symlinks to directories.
Evidently -h is the BSD option for `don't follow symlinks', following
the convention of chmod and other utilities, while -n is the GNU
option; fortunately at least NetBSD ln has had -n too for GNU
compatibility for decades so I'm satisfied with -n. (Neither one is
POSIX.)
Taylor R Campbell [Sat, 10 Aug 2019 15:18:49 +0000 (15:18 +0000)]
Allow hyphenation of log-probability, log-logistic, ill-conditioned.
Can't find a good way to make TeX hyphenate a word that already has a
hyphen in it, so this'll have to do.
Taylor R Campbell [Sat, 10 Aug 2019 15:18:41 +0000 (15:18 +0000)]
Clarify error amplification.
Taylor R Campbell [Sat, 10 Aug 2019 15:18:20 +0000 (15:18 +0000)]
Fix punctuation in display.
Taylor R Campbell [Sat, 10 Aug 2019 15:17:40 +0000 (15:17 +0000)]
Avoid Unicode in texinfo.
Modern LaTeX can handle it but texinfo can't.
Chris Hanson [Sat, 10 Aug 2019 21:31:04 +0000 (14:31 -0700)]
Add missing definition of exact as noticed by GJS.
Also update the text of inexact and exact to match R7RS.
Chris Hanson [Sat, 10 Aug 2019 21:04:08 +0000 (14:04 -0700)]
Fix thinko in previous change.
Chris Hanson [Sat, 10 Aug 2019 05:42:22 +0000 (22:42 -0700)]
Change write to use datum labels only when cycles are present.
This is required by R7RS but was not understood earlier.
Chris Hanson [Mon, 5 Aug 2019 05:05:54 +0000 (22:05 -0700)]
Implement bundle delegation using a more general combinator mechanism.
Taylor R Campbell [Sat, 10 Aug 2019 04:43:58 +0000 (04:43 +0000)]
Need to load sf before host-adapter.scm these days, it seems.
Taylor R Campbell [Sat, 10 Aug 2019 04:22:21 +0000 (04:22 +0000)]
Avoid bash.
bash is not reliably available, and on the systems where it is
available, it is often not installed at /bin/bash.
Taylor R Campbell [Fri, 9 Aug 2019 16:56:01 +0000 (16:56 +0000)]
Fix reading hashed object notation #[foo 123].
Taylor R Campbell [Fri, 9 Aug 2019 16:53:43 +0000 (16:53 +0000)]
Test hashed object notation.
Currently busted for #[foo 123].
Matt Birkholz [Fri, 9 Aug 2019 18:29:48 +0000 (11:29 -0700)]
x11-screen: Fix cut/paste after upcasing X atom names.
Matt Birkholz [Wed, 7 Aug 2019 19:21:35 +0000 (12:21 -0700)]
Do not install non-existent runtime options hashtb and krypt.
Matt Birkholz [Wed, 7 Aug 2019 00:56:39 +0000 (17:56 -0700)]
x11-screen: downcase symbols, most names; fix copyright notices
Matt Birkholz [Wed, 7 Aug 2019 01:01:48 +0000 (18:01 -0700)]
x11: downcase symbols, most names; fix copyright notices
Matt Birkholz [Wed, 7 Aug 2019 00:05:48 +0000 (17:05 -0700)]
pgsql: downcase symbols, most names; fix copyright notices
Matt Birkholz [Tue, 6 Aug 2019 23:57:47 +0000 (16:57 -0700)]
mcrypt: downcase a symbol, most names; fix copyright notices
Matt Birkholz [Wed, 7 Aug 2019 00:51:55 +0000 (17:51 -0700)]
gdbm: downcase symbols, most names; fix copyright notices
Matt Birkholz [Tue, 6 Aug 2019 22:44:33 +0000 (15:44 -0700)]
blowfish: downcase symbols, most names; fix copyright notices
Matt Birkholz [Tue, 6 Aug 2019 22:33:34 +0000 (15:33 -0700)]
ffi: downcase symbols, most names
Matt Birkholz [Tue, 6 Aug 2019 21:38:47 +0000 (14:38 -0700)]
Add pgsql-shim.h as a dependency of pgsql-shim.la.
Matt Birkholz [Tue, 6 Aug 2019 21:36:51 +0000 (14:36 -0700)]
Punt CREF's 9.2-compatible deprecated exports syntax.
Drop support for the awkward, undocumented and hopefully unused
EXPORT-DEPRECATED syntax too.
Matt Birkholz [Wed, 7 Aug 2019 18:44:23 +0000 (11:44 -0700)]
Fix definition of MIT_SCHEME_PKD; use _OS_SUFFIX from src/configure.
Matt Birkholz [Sun, 4 Aug 2019 23:03:35 +0000 (16:03 -0700)]
Edwin/Makefile.am: Include sources.scm. Punt unnecessary overrides.
Matt Birkholz [Sun, 4 Aug 2019 23:22:10 +0000 (16:22 -0700)]
Plugin builds: Improved tags-fix.sh. Handle .cdecl files specially.
Matt Birkholz [Sun, 4 Aug 2019 22:45:58 +0000 (15:45 -0700)]
Plugin builds: Add adapter.c to _shim_la_SOURCES, not _LIBADD.
Matt Birkholz [Sun, 4 Aug 2019 20:52:47 +0000 (13:52 -0700)]
Plugin builds: Use MIT_SCHEME_PKD, not MIT_SCHEME_OS_SUFFIX.
Matt Birkholz [Sun, 4 Aug 2019 22:25:14 +0000 (15:25 -0700)]
Plugin builds: Do not include generated -const.c in dist.
Matt Birkholz [Sun, 4 Aug 2019 23:56:01 +0000 (16:56 -0700)]
Plugin builds: Restore dependence of stamp-scheme on -const.bin.
The stamp-scheme target builds -types.bin, not -const.bin. The
-const.bin comes from plugin-const.scm which comes from ./plugin-const
which comes from -const.c which is a product of stamp-shim.
Matt Birkholz [Sun, 4 Aug 2019 16:59:14 +0000 (09:59 -0700)]
Silence autogen.shs when plugins are built separately.
Matt Birkholz [Sun, 4 Aug 2019 23:06:13 +0000 (16:06 -0700)]
mcrypt/Makefile.am: typo
Matt Birkholz [Sun, 14 Jul 2019 20:40:41 +0000 (13:40 -0700)]
Add subprocess-binary-i/o-port.
Matt Birkholz [Thu, 25 Jul 2019 13:31:43 +0000 (08:31 -0500)]
Plugin Makefile.am improvements.
These were backported from recent improvements to x11/Makefile.am.
+ Use EXEEXT where appropriate.
+ Add MOSTLYCLEANFILES and mostlyclean-local.
+ Use TAGS_FILES and punt the ETAGS_ARGS misuse.
+ Add -adapter.lo to _shim_la_OBJECTS, not _shim_la_LIBADD.
+ Eliminate trailing whitespace.
+ Correct the copyright notices for x11 and x11-screen.
+ Punt stamp-scheme's dependence on -const.bin (redundant to the
dependence on stamp-shim).
Matt Birkholz [Thu, 25 Jul 2019 13:27:59 +0000 (08:27 -0500)]
Silence autogen.shs, which blabber error messages (to Emacs's eye).
Matt Birkholz [Sun, 14 Jul 2019 20:22:47 +0000 (13:22 -0700)]
gdbm: Downcase constants to match case in package descriptions.
Chris Hanson [Sat, 20 Jul 2019 08:33:57 +0000 (04:33 -0400)]
Change symbol<? to delegate to bytevector<?.
This is much faster than string comparison, which matters since symbols should
be fast. The downside is that symbols and strings will sort somewhat
differently, but that shouldn't matter since someone can always sort them using
symbol->string.
Chris Hanson [Sat, 20 Jul 2019 08:33:47 +0000 (04:33 -0400)]
Implement bytevector<?.
Chris Hanson [Sat, 20 Jul 2019 02:08:00 +0000 (22:08 -0400)]
Don't unread #f as if it were a character.
Chris Hanson [Fri, 19 Jul 2019 03:26:56 +0000 (23:26 -0400)]
Edwin: force subprocess I/O ports to use iso-8859-1 coding.
There may still be a problem with synchronous subprocesses, since we don't have
a way to get at those ports. If the process writes UTF-8, then the I/O copier
will try to write unicode chars to a buffer, and I'm not sure what will happen
in that case. It might just ignore the upper bits.
Chris Hanson [Wed, 17 Jul 2019 22:54:49 +0000 (18:54 -0400)]
Treat keyword-only syntax environments differently from runtime environments.
The former are those created by let-syntax and the like; the latter are models
of runtime environments as created by lambda.
This fixes a bug when let-syntax contains a bunch of definitions, which should
be defined in the parent environment of the let-syntax, because it's meaningless
to define them in the let-syntax environment itself. This was previously worked
around by heuristic means, but this change makes the definitions appear in the
correct syntactic environment corresponding to the runtime environment.
Chris Hanson [Wed, 17 Jul 2019 19:55:48 +0000 (15:55 -0400)]
Implement a delegation protocol for bundles.
Chris Hanson [Tue, 9 Jul 2019 23:53:32 +0000 (19:53 -0400)]
Fix stupid typo in reader.
Chris Hanson [Tue, 9 Jul 2019 03:28:20 +0000 (23:28 -0400)]
Fix screw-up in previous host-adapter change.
Chris Hanson [Tue, 9 Jul 2019 03:10:10 +0000 (23:10 -0400)]
Eliminate unused variable from typo.
Chris Hanson [Tue, 9 Jul 2019 02:51:41 +0000 (22:51 -0400)]
Fix a bunch of problems caused by the call-with-values/values change.
First, SF was open-coding these, so that the compiled code wasn't using the new
convention. This caused problems at the boundary between interpreted code and
compiled code, and of course the compiled code was now incorrect. This is fixed
but requires stuff in host-adapter to make it work.
Second, eliminating the open-coding exposed a couple of places that would no
longer initialize correctly during the cold load because they were initialized
prior to the loading of the multiple-values procedures. This is fixed by
rewriting those to not use multiple values and have been marked with comments.
Finally, because the host-adapter file is now changing SF, SF must be loaded
prior to loading the host adapter. There was one case in the make file that
needed to be tweaked to make this guarantee.
Chris Hanson [Tue, 9 Jul 2019 02:48:43 +0000 (22:48 -0400)]
Don't choose the flo:+inf.0/flo:-inf.0 implementations at cold load.
This is wrong because in our public distributions, the cold load is done on
Ubuntu, but the code is supposed to run on any appropriate unix system.
The fix is to make the selection when the band is restored, guaranteeing that
it's running on the target system.
Chris Hanson [Mon, 8 Jul 2019 19:35:03 +0000 (15:35 -0400)]
Add procedure-arity-intersection.
Chris Hanson [Mon, 8 Jul 2019 19:34:09 +0000 (15:34 -0400)]
Change multiple-value return to be slighly closer to correct.
It's never going to be correct, but this at least permits mixing single values
and multiple values a bit.
Chris Hanson [Mon, 8 Jul 2019 19:33:23 +0000 (15:33 -0400)]
Don't use +inf.0 because it throws an exception on macos.
This will need to be fixed but right now it prevents compilation.
Taylor R Campbell [Mon, 8 Jul 2019 00:57:25 +0000 (00:57 +0000)]
Plot the new math functions and their condition numbers.
Plots are done purely in PostScript, so no additional tools required
on top of the existing PostScript/PDF stack we essentially already
depended on. Plots are cubic spline interpolations computed by a
little automatic differentiation library in PostScript.
Fix some mistakes in the prose characterizations of the condition
numbers that I had written.
Taylor R Campbell [Mon, 1 Jul 2019 00:22:21 +0000 (00:22 +0000)]
Fix typo.
Taylor R Campbell [Mon, 1 Jul 2019 00:16:04 +0000 (00:16 +0000)]
Clarify the non-significance of the total ordering.
Taylor R Campbell [Mon, 1 Jul 2019 00:13:38 +0000 (00:13 +0000)]
Tweak some text strength.
Taylor R Campbell [Mon, 1 Jul 2019 00:11:44 +0000 (00:11 +0000)]
Don't call NaN a number.
Taylor R Campbell [Mon, 1 Jul 2019 00:00:31 +0000 (00:00 +0000)]
Fix pasto.
Taylor R Campbell [Sun, 30 Jun 2019 23:44:16 +0000 (23:44 +0000)]
Flesh out an example and fix a typo.
Taylor R Campbell [Sun, 30 Jun 2019 23:28:06 +0000 (23:28 +0000)]
Add flo:signed-lgamma.
Taylor R Campbell [Sun, 30 Jun 2019 23:08:24 +0000 (23:08 +0000)]
Note a few more flonum operations.
Taylor R Campbell [Sun, 30 Jun 2019 22:48:30 +0000 (22:48 +0000)]
Update random number generation section of manual.
Taylor R Campbell [Sun, 30 Jun 2019 22:48:08 +0000 (22:48 +0000)]
Use a trailing 0 for text clarity.
Taylor R Campbell [Sun, 30 Jun 2019 21:59:43 +0000 (21:59 +0000)]
Document floating-point environment, exceptions, rounding modes.
Taylor R Campbell [Sun, 30 Jun 2019 20:52:56 +0000 (20:52 +0000)]
Update documentation for floating-point operations.
Taylor R Campbell [Sun, 30 Jun 2019 19:50:12 +0000 (19:50 +0000)]
Fix flo:ulp on NaN.
Taylor R Campbell [Sun, 30 Jun 2019 19:49:19 +0000 (19:49 +0000)]
flo:ulp is busted on NaN.
Taylor R Campbell [Sun, 30 Jun 2019 19:06:04 +0000 (19:06 +0000)]
Document copysign.
Taylor R Campbell [Sun, 30 Jun 2019 18:58:54 +0000 (18:58 +0000)]
Couple more logsumexp tests.
Taylor R Campbell [Sun, 30 Jun 2019 04:39:33 +0000 (04:39 +0000)]
Document some loggy numerical functions.
Taylor R Campbell [Sun, 30 Jun 2019 04:30:24 +0000 (04:30 +0000)]
Repair mistakes in proofs of some error bounds.
While here:
- Spell out some magic constants.
- Handle and test some edge cases in log1pexp and log1mexp.
- Paginate.
Taylor R Campbell [Thu, 30 May 2019 05:29:56 +0000 (05:29 +0000)]
Expect some failures to signal errors on fp exception traps on arm64.
Chris Hanson [Sat, 29 Jun 2019 21:21:52 +0000 (14:21 -0700)]
Fix calls to read-bytevector! that weren't aware of EOF values.
Chris Hanson [Sun, 9 Jun 2019 19:52:07 +0000 (12:52 -0700)]
Add "adapters" to list of source files.
Chris Hanson [Sun, 9 Jun 2019 04:07:54 +0000 (21:07 -0700)]
Suggest use of macOS command line developer tools rather than Xcode.
Chris Hanson [Sun, 9 Jun 2019 02:20:02 +0000 (19:20 -0700)]
Update make-upload-files to new version.
Chris Hanson [Sat, 8 Jun 2019 21:23:48 +0000 (14:23 -0700)]
Fix incorrect edit.
Chris Hanson [Sat, 8 Jun 2019 05:02:39 +0000 (22:02 -0700)]
Teach reader to find and respect "coding" attribute.
This allows a file to override the default utf-8 coding.
Chris Hanson [Fri, 7 Jun 2019 06:10:07 +0000 (23:10 -0700)]
Make sure that ports use ISO 8859-1 coding.
Chris Hanson [Fri, 7 Jun 2019 05:25:29 +0000 (22:25 -0700)]
Modify CREF to show references to inherited bindings.
This will help track down which parts of the string abstraction need to be
replaced.
Taylor R Campbell [Wed, 29 May 2019 22:17:25 +0000 (22:17 +0000)]
lisppaste is dead.
Taylor R Campbell [Wed, 29 May 2019 21:14:09 +0000 (21:14 +0000)]
Fix bug that caused redrawing whole display on paren flash.
Taylor R Campbell [Wed, 29 May 2019 20:47:46 +0000 (20:47 +0000)]
Hold strong reference to message header while writing summary line.
This way the GC won't be inclined to eat it from under us when we're
just going to parse it again in a moment for the date or subject.
Taylor R Campbell [Wed, 29 May 2019 20:47:35 +0000 (20:47 +0000)]
Tighten encode-cache-namestring.
Taylor R Campbell [Wed, 29 May 2019 20:43:55 +0000 (20:43 +0000)]
Use channel I/O directly for file->string and string->file.
Here a string is an octet sequence, always in US-ASCII or UTF-8, so
we don't need the rigmarole of text I/O.
Taylor R Campbell [Wed, 29 May 2019 16:14:43 +0000 (16:14 +0000)]
Make number of topmost frames with expressions shown configurable.
Taylor R Campbell [Wed, 29 May 2019 16:13:50 +0000 (16:13 +0000)]
Use the Edwin-private %string-append.
No need to pay the cost of wide stuff with string-append*.