From 5a08d15da541915d5c90e0dc02b1fb3e81b07b75 Mon Sep 17 00:00:00 2001
From: Matt Birkholz <matt@birchwood-abbey.net>
Date: Sun, 15 Jun 2025 12:25:47 -0600
Subject: [PATCH] Add "changed_when: false" and "check_mode: false" to certain
 tasks

that use "delegate_to: localhost" to run "readlink /etc/localtime".
---
 README.org                       | 12 +++++++++---
 playbooks/timezone.yml           |  6 +++++-
 roles_t/abbey-tvr/tasks/main.yml |  6 ++++--
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/README.org b/README.org
index cbdf0a8..ed8b63a 100644
--- a/README.org
+++ b/README.org
@@ -2432,14 +2432,16 @@ bitter complaints.
 #+BEGIN_SRC conf :tangle roles_t/abbey-tvr/tasks/main.yml
 
 - name: Get the local timezone.
-  shell: readlink /etc/localtime | sed 's,/usr/share/zoneinfo/,,'
+  shell: readlink /etc/localtime | sed s,/usr/share/zoneinfo/,,
   delegate_to: localhost
+  changed_when: false
+  check_mode: false
   register: timezone
 
 - name: Configure PHP date.timezone.
   become: yes
   lineinfile:
-    regexp: date.timezone ?=
+    regexp: date.timezone *=
     line: date.timezone = {{ timezone.stdout }}
     path: "{{ item }}"
   loop:
@@ -3234,11 +3236,15 @@ if ($ARGV[0] eq "tz") {
   - name: Get timezone.
     command: date '+%Z'
     delegate_to: localhost
+    changed_when: false
+    check_mode: false
     register: zone
 
   - name: Get city.
     shell: readlink /etc/localtime | sed 's,/usr/share/zoneinfo/,,'
     delegate_to: localhost
+    changed_when: false
+    check_mode: false
     register: city
 
   - name: Update timezone.
@@ -3271,7 +3277,7 @@ if ($ARGV[0] eq "tz") {
   - name: Update PHP date.timezone.
     become: yes
     lineinfile:
-      regexp: date.timezone ?=
+      regexp: date.timezone *=
       line: date.timezone = {{ city.stdout }}
       path: "{{ item }}"
     loop:
diff --git a/playbooks/timezone.yml b/playbooks/timezone.yml
index 9b7f958..60c7a5c 100644
--- a/playbooks/timezone.yml
+++ b/playbooks/timezone.yml
@@ -4,11 +4,15 @@
   - name: Get timezone.
     command: date '+%Z'
     delegate_to: localhost
+    changed_when: false
+    check_mode: false
     register: zone
 
   - name: Get city.
     shell: readlink /etc/localtime | sed 's,/usr/share/zoneinfo/,,'
     delegate_to: localhost
+    changed_when: false
+    check_mode: false
     register: city
 
   - name: Update timezone.
@@ -41,7 +45,7 @@
   - name: Update PHP date.timezone.
     become: yes
     lineinfile:
-      regexp: date.timezone ?=
+      regexp: date.timezone *=
       line: date.timezone = {{ city.stdout }}
       path: "{{ item }}"
     loop:
diff --git a/roles_t/abbey-tvr/tasks/main.yml b/roles_t/abbey-tvr/tasks/main.yml
index e538bc2..8e90e89 100644
--- a/roles_t/abbey-tvr/tasks/main.yml
+++ b/roles_t/abbey-tvr/tasks/main.yml
@@ -53,14 +53,16 @@
   notify: Reload Systemd.
 
 - name: Get the local timezone.
-  shell: readlink /etc/localtime | sed 's,/usr/share/zoneinfo/,,'
+  shell: readlink /etc/localtime | sed s,/usr/share/zoneinfo/,,
   delegate_to: localhost
+  changed_when: false
+  check_mode: false
   register: timezone
 
 - name: Configure PHP date.timezone.
   become: yes
   lineinfile:
-    regexp: date.timezone ?=
+    regexp: date.timezone *=
     line: date.timezone = {{ timezone.stdout }}
     path: "{{ item }}"
   loop:
-- 
2.25.1